spelling: Fix spelling errors with codespell #21273

nirs · 2025-08-09T17:23:53Z

Fix trivial spelling errors using codespell[1]:

codespell --skip '*.yaml,*.tmpl,*.json,*.html,*.patch,go.sum' -w

And rejecting some false positives fixes:

./CHANGELOG.md:907: fliter ==> filter
./third_party/go9p/clnt_write.go:48: Writen ==> Written
./third_party/kubeadm/app/features/features.go:69: AtLeast ==> at least
./site/content/en/docs/contrib/translations.md:106: certificats ==> certificates
./site/content/en/docs/contrib/translations.md:113: espace ==> escape
./site/content/en/docs/tutorials/amd.md:75: HSA ==> HAS
./site/content/en/docs/tutorials/amd.md:87: HSA ==> HAS
./pkg/minikube/config/extra_options_test.go:143: expRes ==> express
./pkg/minikube/config/extra_options_test.go:151: expRes ==> express
./pkg/minikube/config/extra_options_test.go:152: expRes ==> express
./pkg/minikube/config/extra_options_test.go:168: expRes ==> express
./pkg/minikube/config/extra_options_test.go:177: expRes ==> express
./pkg/minikube/config/extra_options_test.go:178: expRes ==> express

There are more spelling errors that need manual selection:

./CHANGELOG.md:234: issuse ==> issue, issues
./CHANGELOG.md:543: Pris ==> Prise, Prism
./hack/benchmark/time-to-k8s/page.go:73: readin ==> reading, read in
./hack/benchmark/image-build/generate-chart.go:82: INTERATIVE ==> INTERACTIVE, ITERATIVE
./hack/benchmark/image-build/generate-chart.go:87: INTERATIVE ==> INTERACTIVE, ITERATIVE
./hack/benchmark/image-build/generate-chart.go:137: INTERATIVE ==> INTERACTIVE, ITERATIVE
./hack/benchmark/image-build/generate-chart.go:162: interative ==> interactive, iterative
./hack/benchmark/image-build/generate-chart.go:195: INTERATIVE ==> INTERACTIVE, ITERATIVE
./third_party/go9p/fmt.go:132: Tread ==> Thread, Treat
./third_party/go9p/fmt.go:133: Tread ==> Thread, Treat
./third_party/go9p/p9.go:33: Tread ==> Thread, Treat
./third_party/go9p/p9.go:170: Tread ==> Thread, Treat
./third_party/go9p/p9.go:171: Tread ==> Thread, Treat
./third_party/go9p/p9.go:225: Tread ==> Thread, Treat
./third_party/go9p/p9.go:263: Tread ==> Thread, Treat
./third_party/go9p/packt.go:165: Tread ==> Thread, Treat
./third_party/go9p/packt.go:168: Tread ==> Thread, Treat
./third_party/go9p/srv_srv.go:305: Tread ==> Thread, Treat
./third_party/go9p/srv_srv.go:349: Tread ==> Thread, Treat
./third_party/go9p/unpack.go:170: Tread ==> Thread, Treat
./site/content/en/docs/tutorials/multi_control_plane_ha_clusters.md:145: Virual ==> Virtual, Visual, Viral
./pkg/drivers/krunkit/krunkit.go:392: Terminte ==> Terminate, Termite
./pkg/drivers/common/common.go:283: drawin ==> drawing, draw in, drawn
./pkg/drivers/kic/oci/oci.go:175: stroed ==> stored, stroked, strode
./pkg/minikube/out/out.go:412: isT ==> is, it, its, it's, sit, list
./pkg/minikube/out/out.go:413: isT ==> is, it, its, it's, sit, list
./pkg/minikube/out/out.go:414: isT ==> is, it, its, it's, sit, list
./pkg/minikube/shell/shell_test.go:152: writed ==> wrote, written, write, writer
./pkg/minikube/bootstrapper/kubeadm/kubeadm.go:710: wil ==> will, well

If we find a way to prevent the false positives we can use this command for spell checking in the CI.

[1] https://github.com/codespell-project/codespell

nirs · 2025-08-09T17:33:51Z

/kind improvement

nirs · 2025-08-09T17:56:17Z

/ok-to-test

nirs · 2025-08-09T18:18:22Z

test/integration/guest_env_test.go

@@ -75,7 +75,7 @@ func TestGuestEnvironment(t *testing.T) {
 			mount := mount
 			t.Run(mount, func(t *testing.T) {
 				t.Parallel()
-				rr, err := Run(t, exec.CommandContext(ctx, Targt(), "-p", profile, "ssh", fmt.Sprintf("df -t ext4 %s | grep %s", mount, mount)))


Not sure how this code compiled before - this is a typo in function name. This file has "iso" build tag:

//go:build iso

Naybe we never build and run this code?

interesting yeah I dont see this getting run or even Skipped in our list of tests in a gopogh report
https://storage.googleapis.com/minikube-builds/logs/21174/40884/KVM_Linux.html

medyagh

thank you very much I feel like I am personally responsible for 78% of these spelling errors (admit-abliy)
I could see my tendency of using "-" in words like re-use. !!! thats so me

medyagh · 2025-08-09T21:55:53Z

the Prow Build we need to update the Image to an image not hosted in google to fix it

nirs · 2025-08-09T22:05:42Z

thank you very much I feel like I am personally responsible for 78% of these spelling errors (admit-abliy) I could see my tendency of using "-" in words like re-use. !!! thats so me

I also contributed some of the typos :-)

Fix trivial spelling errors using codespell[1]: codespell --skip '*.yaml,*.tmpl,*.json,*.html,*.patch,go.sum' -w And rejecting some false positives fixes: ./CHANGELOG.md:907: fliter ==> filter ./third_party/go9p/clnt_write.go:48: Writen ==> Written ./third_party/kubeadm/app/features/features.go:69: AtLeast ==> at least ./site/content/en/docs/contrib/translations.md:106: certificats ==> certificates ./site/content/en/docs/contrib/translations.md:113: espace ==> escape ./site/content/en/docs/tutorials/amd.md:75: HSA ==> HAS ./site/content/en/docs/tutorials/amd.md:87: HSA ==> HAS ./pkg/minikube/config/extra_options_test.go:143: expRes ==> express ./pkg/minikube/config/extra_options_test.go:151: expRes ==> express ./pkg/minikube/config/extra_options_test.go:152: expRes ==> express ./pkg/minikube/config/extra_options_test.go:168: expRes ==> express ./pkg/minikube/config/extra_options_test.go:177: expRes ==> express ./pkg/minikube/config/extra_options_test.go:178: expRes ==> express There are more spelling errors that need manual selection: ./CHANGELOG.md:234: issuse ==> issue, issues ./CHANGELOG.md:543: Pris ==> Prise, Prism ./hack/benchmark/time-to-k8s/page.go:73: readin ==> reading, read in ./hack/benchmark/image-build/generate-chart.go:82: INTERATIVE ==> INTERACTIVE, ITERATIVE ./hack/benchmark/image-build/generate-chart.go:87: INTERATIVE ==> INTERACTIVE, ITERATIVE ./hack/benchmark/image-build/generate-chart.go:137: INTERATIVE ==> INTERACTIVE, ITERATIVE ./hack/benchmark/image-build/generate-chart.go:162: interative ==> interactive, iterative ./hack/benchmark/image-build/generate-chart.go:195: INTERATIVE ==> INTERACTIVE, ITERATIVE ./third_party/go9p/fmt.go:132: Tread ==> Thread, Treat ./third_party/go9p/fmt.go:133: Tread ==> Thread, Treat ./third_party/go9p/p9.go:33: Tread ==> Thread, Treat ./third_party/go9p/p9.go:170: Tread ==> Thread, Treat ./third_party/go9p/p9.go:171: Tread ==> Thread, Treat ./third_party/go9p/p9.go:225: Tread ==> Thread, Treat ./third_party/go9p/p9.go:263: Tread ==> Thread, Treat ./third_party/go9p/packt.go:165: Tread ==> Thread, Treat ./third_party/go9p/packt.go:168: Tread ==> Thread, Treat ./third_party/go9p/srv_srv.go:305: Tread ==> Thread, Treat ./third_party/go9p/srv_srv.go:349: Tread ==> Thread, Treat ./third_party/go9p/unpack.go:170: Tread ==> Thread, Treat ./site/content/en/docs/tutorials/multi_control_plane_ha_clusters.md:145: Virual ==> Virtual, Visual, Viral ./pkg/drivers/krunkit/krunkit.go:392: Terminte ==> Terminate, Termite ./pkg/drivers/common/common.go:283: drawin ==> drawing, draw in, drawn ./pkg/drivers/kic/oci/oci.go:175: stroed ==> stored, stroked, strode ./pkg/minikube/out/out.go:412: isT ==> is, it, its, it's, sit, list ./pkg/minikube/out/out.go:413: isT ==> is, it, its, it's, sit, list ./pkg/minikube/out/out.go:414: isT ==> is, it, its, it's, sit, list ./pkg/minikube/shell/shell_test.go:152: writed ==> wrote, written, write, writer ./pkg/minikube/bootstrapper/kubeadm/kubeadm.go:710: wil ==> will, well If we find a way to prevent the false positives we can use this command for spell checking in the CI. [1] https://github.com/codespell-project/codespell

nirs · 2025-08-10T01:32:21Z

Rebased to consume the docker service fix

minikube-pr-bot · 2025-08-10T03:04:16Z

kvm2 driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21273 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 50.8s    │ 51.3s                  │
│ enable ingress │ 16.6s    │ 15.9s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 47.7s 48.6s 52.2s 53.5s 51.9s
Times for minikube (PR 21273) start: 48.4s 48.8s 55.1s 52.0s 52.1s

Times for minikube (PR 21273) ingress: 16.0s 16.0s 15.6s 15.6s 16.0s
Times for minikube ingress: 16.0s 16.1s 15.5s 16.0s 19.5s

docker driver with docker runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21273 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 24.2s    │ 25.7s                  │
│ enable ingress │ 13.3s    │ 12.8s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube start: 23.3s 25.6s 25.1s 22.9s 24.0s
Times for minikube (PR 21273) start: 25.5s 26.0s 23.6s 26.7s 26.9s

Times for minikube ingress: 13.3s 13.3s 12.8s 13.8s 13.3s
Times for minikube (PR 21273) ingress: 13.3s 12.3s 13.4s 12.9s 12.3s

docker driver with containerd runtime

┌────────────────┬──────────┬────────────────────────┐
│    COMMAND     │ MINIKUBE │ MINIKUBE  ( PR 21273 ) │
├────────────────┼──────────┼────────────────────────┤
│ minikube start │ 22.3s    │ 22.8s                  │
│ enable ingress │ 23.2s    │ 26.2s                  │
└────────────────┴──────────┴────────────────────────┘

Times for minikube ingress: 23.8s 22.8s 22.8s 23.8s 22.8s
Times for minikube (PR 21273) ingress: 22.8s 23.8s 22.8s 38.8s 22.8s

Times for minikube start: 21.5s 23.7s 23.0s 20.9s 22.5s
Times for minikube (PR 21273) start: 22.3s 25.2s 22.1s 21.9s 22.6s

medyagh · 2025-08-11T18:27:16Z

/lgtm

k8s-ci-robot · 2025-08-11T18:27:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, nirs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Fix trivial spelling errors using codespell[1]: codespell --skip '*.yaml,*.tmpl,*.json,*.html,*.patch,go.sum' -w And rejecting some false positives fixes: ./CHANGELOG.md:907: fliter ==> filter ./third_party/go9p/clnt_write.go:48: Writen ==> Written ./third_party/kubeadm/app/features/features.go:69: AtLeast ==> at least ./site/content/en/docs/contrib/translations.md:106: certificats ==> certificates ./site/content/en/docs/contrib/translations.md:113: espace ==> escape ./site/content/en/docs/tutorials/amd.md:75: HSA ==> HAS ./site/content/en/docs/tutorials/amd.md:87: HSA ==> HAS ./pkg/minikube/config/extra_options_test.go:143: expRes ==> express ./pkg/minikube/config/extra_options_test.go:151: expRes ==> express ./pkg/minikube/config/extra_options_test.go:152: expRes ==> express ./pkg/minikube/config/extra_options_test.go:168: expRes ==> express ./pkg/minikube/config/extra_options_test.go:177: expRes ==> express ./pkg/minikube/config/extra_options_test.go:178: expRes ==> express There are more spelling errors that need manual selection: ./CHANGELOG.md:234: issuse ==> issue, issues ./CHANGELOG.md:543: Pris ==> Prise, Prism ./hack/benchmark/time-to-k8s/page.go:73: readin ==> reading, read in ./hack/benchmark/image-build/generate-chart.go:82: INTERATIVE ==> INTERACTIVE, ITERATIVE ./hack/benchmark/image-build/generate-chart.go:87: INTERATIVE ==> INTERACTIVE, ITERATIVE ./hack/benchmark/image-build/generate-chart.go:137: INTERATIVE ==> INTERACTIVE, ITERATIVE ./hack/benchmark/image-build/generate-chart.go:162: interative ==> interactive, iterative ./hack/benchmark/image-build/generate-chart.go:195: INTERATIVE ==> INTERACTIVE, ITERATIVE ./third_party/go9p/fmt.go:132: Tread ==> Thread, Treat ./third_party/go9p/fmt.go:133: Tread ==> Thread, Treat ./third_party/go9p/p9.go:33: Tread ==> Thread, Treat ./third_party/go9p/p9.go:170: Tread ==> Thread, Treat ./third_party/go9p/p9.go:171: Tread ==> Thread, Treat ./third_party/go9p/p9.go:225: Tread ==> Thread, Treat ./third_party/go9p/p9.go:263: Tread ==> Thread, Treat ./third_party/go9p/packt.go:165: Tread ==> Thread, Treat ./third_party/go9p/packt.go:168: Tread ==> Thread, Treat ./third_party/go9p/srv_srv.go:305: Tread ==> Thread, Treat ./third_party/go9p/srv_srv.go:349: Tread ==> Thread, Treat ./third_party/go9p/unpack.go:170: Tread ==> Thread, Treat ./site/content/en/docs/tutorials/multi_control_plane_ha_clusters.md:145: Virual ==> Virtual, Visual, Viral ./pkg/drivers/krunkit/krunkit.go:392: Terminte ==> Terminate, Termite ./pkg/drivers/common/common.go:283: drawin ==> drawing, draw in, drawn ./pkg/drivers/kic/oci/oci.go:175: stroed ==> stored, stroked, strode ./pkg/minikube/out/out.go:412: isT ==> is, it, its, it's, sit, list ./pkg/minikube/out/out.go:413: isT ==> is, it, its, it's, sit, list ./pkg/minikube/out/out.go:414: isT ==> is, it, its, it's, sit, list ./pkg/minikube/shell/shell_test.go:152: writed ==> wrote, written, write, writer ./pkg/minikube/bootstrapper/kubeadm/kubeadm.go:710: wil ==> will, well If we find a way to prevent the false positives we can use this command for spell checking in the CI. [1] https://github.com/codespell-project/codespell

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 9, 2025

k8s-ci-robot requested review from ComradeProgrammer and medyagh August 9, 2025 17:24

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2025

nirs force-pushed the spelling branch from 2ef6830 to c634142 Compare August 9, 2025 17:27

nirs changed the title ~~spelling: Fix spelling error with codespell~~ spelling: Fix spelling errors with codespell Aug 9, 2025

k8s-ci-robot added the kind/improvement Categorizes issue or PR as related to improving upon a current feature. label Aug 9, 2025

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 9, 2025

nirs commented Aug 9, 2025

View reviewed changes

medyagh approved these changes Aug 9, 2025

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2025

nirs force-pushed the spelling branch from c634142 to 55bd21f Compare August 10, 2025 01:30

medyagh merged commit 62529ec into kubernetes:master Aug 11, 2025
26 of 37 checks passed

k8s-ci-robot assigned medyagh Aug 11, 2025

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

spelling: Fix spelling errors with codespell #21273

spelling: Fix spelling errors with codespell #21273

Uh oh!

nirs commented Aug 9, 2025 •

edited

Loading

Uh oh!

nirs commented Aug 9, 2025

Uh oh!

nirs commented Aug 9, 2025

Uh oh!

nirs Aug 9, 2025

Uh oh!

medyagh Aug 9, 2025

Uh oh!

medyagh left a comment •

edited

Loading

Uh oh!

medyagh commented Aug 9, 2025

Uh oh!

nirs commented Aug 9, 2025

Uh oh!

nirs commented Aug 10, 2025

Uh oh!

minikube-pr-bot commented Aug 10, 2025

Uh oh!

medyagh commented Aug 11, 2025

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 11, 2025

Uh oh!

Uh oh!

spelling: Fix spelling errors with codespell #21273

spelling: Fix spelling errors with codespell #21273

Uh oh!

Conversation

nirs commented Aug 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nirs commented Aug 9, 2025

Uh oh!

nirs commented Aug 9, 2025

Uh oh!

nirs Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

medyagh Aug 9, 2025

Choose a reason for hiding this comment

Uh oh!

medyagh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

medyagh commented Aug 9, 2025

Uh oh!

nirs commented Aug 9, 2025

Uh oh!

nirs commented Aug 10, 2025

Uh oh!

minikube-pr-bot commented Aug 10, 2025

Uh oh!

medyagh commented Aug 11, 2025

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 11, 2025

Uh oh!

Uh oh!

nirs commented Aug 9, 2025 •

edited

Loading

medyagh left a comment •

edited

Loading